Cristelknight999 / Expanded-Ecosphere

A realistic Minecraft worldgen mod.
32 stars 9 forks source link

Crash with Region Unexplored #66

Closed BlackAures1 closed 8 months ago

BlackAures1 commented 10 months ago

https://github.com/UHQ-GAMES-MODS/REGIONS_UNEXPLORED_FORGE/issues/50#issuecomment-1783693963 https://github.com/UHQ-GAMES-MODS/REGIONS_UNEXPLORED_FORGE/issues/49

forwarding these two to you.

image

UHQ-GAMES commented 10 months ago

hey there! thought id drop my findings here! In a crash log from @BlackAures1 and it looks like a FOC between our biomes on WWOO 3.1.9+ in 1.19.2 and it looks to be the same one we had from the 1.20 versions.

java.lang.IllegalStateException: Feature order cycle found, involved sources: [Reference{ResourceKey[minecraft:worldgen/biome / regions_unexplored:rainforest]=net.minecraft.world.level.biome.Biome@2525cabb}, Reference{ResourceKey[minecraft:worldgen/biome / wythers:jungle_island]=net.minecraft.world.level.biome.Biome@2651cca8}]

so I looked into the biomes and i found that in the jungle_island json there is "minecraft:patch_melon_sparse", "minecraft:vines"

while my rainforest and vanilla sparse_jungle have it the other way around.

if you need any other information I'm happy to help out!

catter1 commented 9 months ago

Oops, I accidentally duplicated this issue in #74 - but I offered a bit of analysis as well, and referenced a different biome. Maybe it will be helpful

BlackAures1 commented 9 months ago

Any news on this crash?

Cristelknight999 commented 8 months ago

i don't think i'll upload another 1.19.2 version

Cristelknight999 commented 8 months ago

actually i can't even get it to crash. weird

catter1 commented 8 months ago

Previously, I was able to recreate the crash on 1.19.4 - I don't think it happens in 1.19.2. Although it theoretically could - I'm assuming there's a change in RU that triggers it.

Anyways, I just tried to recreate it, and I got an unrelated crash. Maybe you'd be interested in it.

https://mclo.gs/xcgS1K6

Mods - Cloth Config 10.1.105 - FAPI 0.87.2+1.19.4 - Forge Config API Port 6.0.2 - Regions Unexplored 0.4.1+1.19.4 - TerraBlender 2.3.0.22 - WWOO 3.1.13