CristianHenzel / ClipIt

ClipIt clipboard manager for GTK+
https://github.com/CristianHenzel/ClipIt
GNU General Public License v3.0
645 stars 83 forks source link

Manage history bug in V1.4.5 #134

Open Rava77 opened 4 years ago

Rava77 commented 4 years ago

When using the Manage history in V1.4.5 x86-64 running XFCE I encounter the following bug: I delete some entries, and exit the "Manage History" with [Close] and click the Notification Area Icon of "Clipboard manager" to see if all worked well. Usually some entries I selected and removed in "Manage History" are still present, instead other entries I did not select and did not delete in "Manage History" are deleted.

That entries are not deleted is annoying but this can be fixed by going to the "Manage History" window once again. But deleted entries that I did not delete in "Manage History" are worse since I do not make every time a screenshot to be able to remember the entries I wanted to keep.

This happens when there are more than one entry to delete, usually I want to delete 5 to 15 or 20 unneeded entries in one go, the more entries I try to delete the more likely the bug happens, when I want to delete 10 or more entries the bug happens every time. Like in #21, usually there is a gap between entries I delete, so that entries I want to keep are always in between the ones I delete. In "Manage History" what I did always looks like I wanted it, but after exiting the "Manage History" window usually the result is not what I did do in "Manage History".

I have no idea if my repeatable bug is similar to issue #21 - manage history "remove" doesn't completely work. Like in #21, I can do the deleting entries repeatedly and report it graphically if that would be helpful.

sidmint commented 3 years ago

I'm another witness to this problem since long, happens very frequently/almost all the time and very easy to reproduce. Also happens if I delete multiple items one at a time. Above explanation is good that some entries are still present after deleting from the "Manage History" and other entries not deleted gets deleted. Even static items get deleted if they are nearby the deleted items and this annoys me more as I need to reenter them manually. I try not to delete anything from history to avoid this but sometimes it's required, you know. Linuxmint 19.3 xfce, ver 1.4.2 [didnt check 1.4.5 but since above person mentioned 1.4.5 so i think it's still present]

anyway, i found clipit best in the linux world, particularly the feature of "show indexes in history menu" which allows one to paste selectively from the list by just pressing a number key [autopaste enabled]. Is this present anywhere else in Linux clipboards? I didnt find any. Thank you so much.

Rava77 commented 3 years ago

@ sidmint

The only way avoiding the unwanted deletion (unless the author of the program decides to fix the issue) is this:

Considering the following entries. Entries starting with a number are ones you want deleted, entries starting with characters are ones you want to keep:

1 2 3 a b 4 c 5 6 d e 7 f g […]

Now, you cannot just delete all lines in one go. You have to go into Manage History and only delete 1 2 3

then exit history, and re-enter it, this time only deleting 4

again, exit history, entering it again, this time only deleting lines 5 6

again, exit, re-enter, and only delete line 7

Etcetera. It is quite bothersome, but the only way to only delete what you want to delete, and not get a line you not deleted deleted anyway by the unfixed bug.

sidmint commented 3 years ago

@Rava77 that is indeed helpful, thank you, i didn't know that. What I wrote above "Also happens if I delete multiple items one at a time." is perhaps because I did not exit each time.

Rava77 commented 3 years ago

^ My way is working, but you can only delete consecutive entries in one go, you can never skip over even a single line you want to keep and so delete non-consecutive entries. ( I did use the seemingly long-winded example above for good reason. ) Still I hope the bug could be fixed.