Don't write to primary clipboard unless "use primary" pref is set - Githubissues

CristianHenzel / ClipIt

ClipIt clipboard manager for GTK+

https://github.com/CristianHenzel/ClipIt

GNU General Public License v3.0

648 stars 84 forks source link

Don't write to primary clipboard unless "use primary" pref is set #73

Closed Epskampie closed 6 years ago

Epskampie commented 7 years ago

This seems logical behaviour, when "use primary" is disabled, the program should not touch it in any way. Especially since the "synchronize clipboard" pref is auto-disabled in this case.

This actually works around a bug with sublime text as well, where the selection is lost when the primary clipboard is overwritten.

On the other hand, people might expect to be able to paste with middle mouse button always, dunno.

onlyjob commented 6 years ago

Could you please provide more details about how to reproduce the problem? What is your Desktop Environment? Thanks.

Epskampie commented 6 years ago

The problem seems to have already been resolved in the newest gnome or sublime text.

onlyjob commented 6 years ago

Still, your patch looks like a good improvement except that I could not see any difference with or without it on Cinnamon... Maybe there are situations/enviroments where it matters...

Epskampie commented 6 years ago

For your information then, steps to reproduce (before):

Disable autopaste and "use primary" in clipit.
Open sublime, put cursor in the middle of a sentence.
Press the shortcut to open clipit, select something, press enter.
Notice that sublime doesn't regain focus, and you have to press alt+tab or something to get it back.

onlyjob commented 6 years ago

Thanks. However sublime is a proprietary(!) editor hence not suitable as reproducer and ultimately not worth using or wasting time for its troubleshooting.

Epskampie commented 6 years ago

No shit sherlock. 😄

I mentioned sublime in my first post. Next time please read before wasting my time.

onlyjob commented 6 years ago

I just didn't know what it is... After your reply I thought I'll check if I can reproduce the problem with software you've mentioned... IMHO it is a hypocrisy to say that we are wasting your time here by pointing out that you seek help of open source community to troubleshoot proprietary software.
Proprietary == unethical.

Epskampie commented 6 years ago

Won’t get into that last point, had too many of those discussions in college.

FYI: I was not asking for help, but providing a solution in the form of code. Use it or don’t, I don’t care.

onlyjob commented 6 years ago

Fair enough. Thanks. I appreciate your contribution. I still think that your patch might be worthy of inclusion if we can find/demonstrate where it is useful.