CristianHenzel / ClipIt

ClipIt clipboard manager for GTK+
https://github.com/CristianHenzel/ClipIt
GNU General Public License v3.0
648 stars 84 forks source link

Fix issues with newer versions of gtk #90

Closed colonelpanic8 closed 5 years ago

CristianHenzel commented 6 years ago

Hello,

if you could redo the pull request without the "Remove check for mouse button state" commit, I would gladly pull it. That check is actually needed to prevent lots of entries into the history if the mouse button is held down for a long time while selecting text, so I'm not sure why you removed it. Or am I missing something?

colonelpanic8 commented 6 years ago

@CristianHenzel In gtk3, those calls are deprecated and produce a ton of output. I don't often select for longer than a second so I didn't really mind this, but I can revert that last change if you would prefer. They should really be changed to using the device interface though.

CristianHenzel commented 6 years ago

Yes, please revert that change.

colonelpanic8 commented 6 years ago

@CristianHenzel change reverted. Merge?