search

CristianLara / canoe-flights

Canoe - Inexpensive flight and location explorer
http://canoesave.me
MIT License
2 stars 0 forks source link

[Feature #25] Remove submit button #35

Closed japalio closed 6 years ago

japalio commented 6 years ago

See https://github.com/StanfordCS194/Cristian-Dan-Jenny-Matthew-Neven/issues/25

CristianLara commented 6 years ago

LGTM

CristianLara commented 6 years ago

Actually I think something important to add here would be some kind of loading indicator when we are loading new data. This used to be indicated by the submit button going inactive and saying Loading... but now we need some other way to indicate this.

I've already made a loading variable in the state that is true when we are waiting for the api response and false otherwise. You can use this variable to conditionally show an html element.

CristianLara commented 6 years ago

Here are some awesome libraries for cool loading indicators:

http://kyleamathews.github.io/react-spinkit/

https://github.com/expo/react-loading-indicator