CristianVasile23 / conversation-hud

A simple FoundryVTT module that adds a nice HUD that display the portraits of all the characters present in a conversation.
MIT License
17 stars 3 forks source link

when opening the game i have three instances on? #73

Open ThingsCouldGetDicey opened 2 months ago

ThingsCouldGetDicey commented 2 months ago

image im not sure whats going on. but ever since ive used the mod it spams players for permissions. and then its acting like this.

ThingsCouldGetDicey commented 2 months ago

when trying to close them it has the error message of no active conversation found.

CristianVasile23 commented 2 weeks ago

Hey, sorry for the late reply.

Regarding the issue with the insufficient rights, I have identified the cause and I will push a fix as soon as possible.

Regarding the other issue you have, the reason why there are three instances is due to a fault in the way I created the logic of the module. Correct me if I am wrong, but do you have multiple GMs in your game? If so, that is the cause.

The way this happens is that on certain occasions, when there are multiple users with GM rights (assistant GMs count), the code for creating/displaying conversation is ran for each of the participating GMs, which leads to multiple instances of the same conversation appearing. That is a fault in the core framework of the module which is why I have started a complete rewrite to take into account such situations and handle them properly not with patch fixes.

The good news is, if this is the issue, a simple refresh should fix it. That said, can you please provide more details as to how this occurs? Some step by step instructions would be greatly appreciated so that I may be able to better help you.

Thanks in advance!