CriticMarkup / CriticMarkup-toolkit

Various tools to use CriticMarkup in your daily workflow
730 stars 51 forks source link

Highlights Example #38

Open camoy opened 8 years ago

camoy commented 8 years ago

In the specification under the highlights section the comment has class="critic metadata". Should this not be class="critic comment"?

vimtaai commented 5 years ago

I'm in the middle of a JavaScript implementation of a basic CriticMarkup parser and my test suites (based on the examples provided on your "specs" site) failed due to this discrepancy. It would be nice to know the intended output of hightlights:

Lorem {==ipsum==}{>>doesn't make sense<<} dolor sit amet...

should become:

  1. Lorem <mark>ispum</mark><span class="critic metadata">doesn't make sense<span> dolor sit amet...
  2. Lorem <mark>ispum</mark><span class="critic comment">doesn't make sense<span> dolor sit amet...

Which one is the intended output?