search

Critical-Impact / InventoryTools

Dalamud plugin for inventory tracking
GNU General Public License v3.0
41 stars 28 forks source link

Lag when looting an item #142

Closed drejjmit closed 2 years ago

drejjmit commented 2 years ago

Describe the bug Each time i loot an item i get a ~60ms lag spike

To Reproduce Easiest to notice is if you're 'Quick Synthesis' 99 items. Each item received triggers a 50-70ms lag spike

Screenshots image

When i stop looting / crafting, the lag is gone image

Version 1.2.0.3

drejjmit commented 2 years ago

Just interacting with anything seems to makes the InventoryMonitor::FrameworkOnUpdate cause a lagspike. I just interacted with a Oasis Flowerpot in my estate and it shot up to 220ms from just clicking it. No items were looted. image

Critical-Impact commented 2 years ago

I'm aware, I'm honestly not sure at this point, I'm still investigating but I'm finding it very difficult to replicate consistently.

drejjmit commented 2 years ago

Must be in the Lib. I get the same lag when only using InventorySearchBar that uses your CriticalCommonLib https://github.com/Tischel/InventorySearchBar

Critical-Impact commented 2 years ago

Can you let me know if the issue is still a problem in the latest release? Have done what I can to make the scanning process run outside of the game's main update loop.

Obviously if you still have InventorySearchBar running you will probably see the issue as they might not have updated their CCL dependency.

drejjmit commented 2 years ago

Much better now. Thank you. I'll make a new/reopen this issue if i notice anything.