search

Critical-Impact / InventoryTools

Dalamud plugin for inventory tracking
GNU General Public License v3.0
41 stars 28 forks source link

"Equippable By" class filter yields no results in French for certain classes #158

Closed BSoD38 closed 1 year ago

BSoD38 commented 2 years ago

Describe the bug The plugin will sometimes yield 0 results when the game is in French and you filter by class, even when it oviously should.

To Reproduce Steps to reproduce the behavior:

  1. Set the game to french
  2. Filter "All Game Items" with "Equippable by" set to Mage bleu (Blue mage), Invocateur (Summoner), Élémentaliste (Conjurer)...
  3. There are no results displayed

Expected behavior There are results for the selected class.

Screenshots bug

Dalamud Information: Release version of Dalamud (7.0.0.8)

Filter Issues As said above, there are several classes that yield no results when the game is in French.

Additional context This is probably caused by the fact that some classes in French have completely different names (and therefore the diminutives as well). SMN is INV, CUL is CUI, DRK is CHN, etc. I'd guess the same issue exists for players that play the game in German.

Critical-Impact commented 1 year ago

So while this is out on the current live version the filter itself is broken, I've got a fix prepared and it will be in the next version.