Missing NPCs from More Information

[Taurenkey]

Describe the bug When looking up more information on items, if the item has shops/vendors that share inventories then only one will be listed. For example, items from the GC vendors will only list the Flames Quartermaster, even though you can buy the same item from the other 2 GC quartermasters. This also applies to NPCs like the Calamity Salvagers, it will only list the one in Ul'dah. This also seems to make some items just omit having vendors, such as Iron Ore, which can be purchased from 6 different vendors but the plugin doesn't report any of them.

To Reproduce Steps to reproduce the behavior:

• Look at the more information window for certain items such as those listed above and check the shops heading.

Expected behavior All vendors to be listed for all items.

Screenshots

[Critical-Impact]

So there's a few things happening here, 1) I did have a artificial limit in the logic that'd only show items from GC vendors based on your characters GC. I've removed this in the testing version that is coming out. 2) Calamity salvagers are a different matter and I'll look into it 3) The vendors for iron ore, which ones don't show up?

[Taurenkey]

For the iron ore one, none of them. There's a vendor in Limsa that sells it (Soemrwyb) along with vendors in the housing districts. There's 2 vendors listed in the GilShop sheet for it, one of which will be the NPC in Limsa and the other one is the vendor but for the housing districts NPCs.

I realise I picked a low level item, but from my experiences with going on a craft binge sometimes it's the lower level stuff that you need to remember if it's on a vendor or not for convenience.

[github-1348A55]

I myself have recently noticed that some vendors are not showing up. "Limsa Lominsa" all vendors information not displayed, but "each La Noscea" all vendors information is displayed. "Gridania" and "each Shroud" all vendors information is not displayed. "Ul'dah" and "each Thanalan" all vendors information is displayed.

"Ul'dah" and "each Thanalan" and "each La Noscea" are probably no problems. "Limsa Lominsa" and "Gridania" and "each Shroud (sylphic vendor only displayed)" are probably having problems.

It is still unclear if there are cases where other countries or vendors are not listed.

[Critical-Impact]

Please try the latest version, I've added in some vendors manually as their data does not appear in the game. I've unlocked vendors that might not have actual locations and calamity salvager shops should show up now.

I can find vendors in Lumsa Lominsa, if you can't find a specific vendor can you let me know which one?

[Critical-Impact]

Closing this, there is an update coming out that should fix the subdivisions and a few of the locations being wrong but as far as I know that should cover the NPCs brought up in this ticket.