search

Critical-Impact / InventoryTools

Dalamud plugin for inventory tracking
GNU General Public License v3.0
41 stars 28 forks source link

Items with a # in their name point to a false ConsoleGamesWiki URL #251

Closed GayPotatoEmma closed 4 months ago

GayPotatoEmma commented 5 months ago

Describe the bug When pressing the Console Games Wiki button in the more information tab for an item with a # in its name (Mammet #​001, Protomyke #​987 as examples), it gets sent to a wrong url.

To Reproduce Steps to reproduce the behavior:

  1. Right click on an item with a # in its name (Mammet #​001, Protomyke #​987 as examples) and select More Information
  2. Press the console games wiki button

Expected behavior It opens the correct link like with the other items.

Screenshots image

Dalamud Information: Do you have testing enabled? Yes

Filter Issues N/A

Additional context For reference, the Protomyke gets linked as https://ffxiv.consolegameswiki.com/wiki/Protomyke#987 whereas the correct URL is https://ffxiv.consolegameswiki.com/wiki/Protomyke_987. They also mention the omission of the # due to technical reasons right at the top of the article image This also seems to apply to some GamerEscape links as the Mammet #​001 link is also broken on there whereas the Protomyke #987 does work properly

GayPotatoEmma commented 4 months ago

Confirmed fixed with AT 1.7.0.9 so closing this issue. Thank you for the fix.