Closed LouisDeconinck closed 1 month ago
The changes involve restructuring the navigation menu and footer links in the +layout.svelte
file to utilize dynamic arrays for rendering. This replaces the previous hardcoded links with a more maintainable approach, enhancing the flexibility and readability of the code.
Files | Change Summary |
---|---|
src/routes/(marketing)/... |
Refactored navigation menu and footer links to use dynamic arrays for rendering. |
Objective | Addressed | Explanation |
---|---|---|
Easy menu editing (#124) | ✅ |
In fields of code, I hop with glee,
Menus now dance, so wild and free!
Links are gathered, neat as can be,
A rabbit's joy, oh can't you see?
With every click, the world feels bright,
Dynamic dreams take joyful flight! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Just noticed that this approach will not work if the SVG icon consists out of multiple paths.
Hey @LouisDeconinck thanks for the PRs, but take a look my comments on your issues yesterday, like here: https://github.com/CriticalMoments/CMSaasStarter/issues/124#issuecomment-2315816691
We don't want to make CMSaasStarter too much like a framework where you're learning custom things that only work in a specific framework. It should be as close to standard Svelte+tailwind as possible. The goal is to be a template with good Svelte+tailwind implementation, you fork, and then fit to your needs. We expect everyone will need to customize it a bit before shipping, and that's okay.
Aka:
Changes like #129 and #126 look good though!
Added two constants containing the menu items & footer links. This reduces duplication for the menu and allows for easier editing. It could also be possible to add this to the config.ts file if that is preferred. Fixes #124
Summary by CodeRabbit