scosman
commented
7 months ago Wow, what a list! Thank for the patches/interest!
Lots of thoughts, typed quickly. Ignore typos please đ. Also moving to discussion vs issue once I figure out GitHub buttons.
A key goal for the projects: keep the template so itâs a quick âfork and goâ. I donât want to add a bunch of setup steps. Itâs a template for capable devs to fork run with, not a one stop shop. Iâm all for things that are easy optional extensions most projects need. Iâm for adding features that are 1) likely to be needed by a wide range of saas apps and arenât too specific, 2) donât increase the mental load of working in the codebase, 3) donât add extra setup steps. Optional steps that give you cool features, that are well isolated and can be ignored, arenât too niche, and are safe from security POV: all for it.
As an example, even though I recommend Cloudflare Pages, I keep the generic adapter so any platform works with zero config.
My general workflow: build cool things on template, and back port when I think they could be useful to a lot of others.
To answer your list:
- Cookies: I have this in my other repo. I should port it. I hate site-wide banners, and instead add it to the login pages where cookies will be added if you click a button.
- Dark mode: P2/P3 for me. I donât see too many companies offering 2 themes. Most care about brand consistency more. If itâs optional and doesnât complicate existing codebase, maybe. Would have to see PR.
- Two factor auth: would love this one! Great addition.
- Leaked password protection: seems good if optional + clean. But P2.
- CSP: yes!
Later things
- Web share: wasnât familiar, but looks cool! Would wait for broader adoption before building it into template though: [Web Share API | Can I use... Support tables for HTML5, CSS3, etc](https://caniuse.com/web-share).
Things that seem too niche:
- image uploader: lots of projects need this, but I think it can be an add on once you fork. There are different destinations (Supabase, S3, Google, Azure, custom), different reqs on size/transcoding/formats/transparency, etc. Atack vectors. Once you start to unpeel this onion, you just find more and more layers (trust meâŠ). Better to add speciality library than put in a few basic options and face a never-ending stream of bugs/requests.
- Web Push: nothing in template needs push. Most sites donât need/use it. I think folks can add it post fork if they need it, without complicating core.
- Sentry: love Sentry, but doesnât feel like it needs to be at template level. A capable dev can add quickly it if they want it (or a competing option).
- PWA: donât see most SaaS sites needing this. Seems like good addition post fork. If we need to make some changes to core to make adding it easier, sure!
Unsure:
- Full-text search: whatâs the use case? Blog content? Blog content isnât in Postgres, and building a full blown CMS would be too much. For blog Iâd prefer compile time JS option like fuse/search-index/lunr/hugo-search-tools. Still P2/P3. But cool tech sooooooâŠ
I'm planning on using this starter for one of my projects and there are some things I want to add. Curious to hear if I should encapsulate some of them, that you would be interested in and make a PR(s). Before I do unnecessary work that you don't think fits into this project, here is a rough list I was thinking about.
Daisy UI:
<html data-theme="dark")Supabase:
JS/HTML:
navigator.share())<meta http-equiv="Content-Security-Policy")Additional: