search

CriticalPathTraining / PowerBiEmbedded

Resources and Sample Files associated with Ted Pattison's Power BI Embedded webinar
MIT License
58 stars 50 forks source link

Update aadAuthorizationEndpoint #5

Open rudivs opened 6 years ago

rudivs commented 6 years ago

ADAL 4.x does not accept https://login.windows.net/common/oauth2/authorize as a valid auth endpoint (see https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/issues/1346). This PR updates DailyReporterPro and EmbeddedLab to use https://login.microsoftonline.com/common instead.

Note: this has not been tested with ADAL < 4.3, which may not work with this endpoint.

TedPattison commented 6 years ago

Thanks, I just ran into this on another project when moving from ADAL.NET 3.18 to 4.3. I found the same solution as you did. Thanks