search

Crivaledaz / Mattermost-LDAP

This module provides an external LDAP authentication in Mattermost for the Team Edition (free).
MIT License
365 stars 72 forks source link

Some adjustments #92

Closed WanpengQian closed 2 years ago

WanpengQian commented 2 years ago
  1. optimize default login page layout.
  2. should not check password minimal length since we are not creating passwords.
  3. using displayName instead of cn when displayName is available. before after
Crivaledaz commented 2 years ago

Thank you very much for your work. I am sorry to review it only now.

I have tested it, and it works perfectly with or without the displayName attribute. I agree with you, this attribute should be used if it is defined, but as you stated in #89 we cannot assume it always exists since it is not a MUST in common schemes.

Your page layout settings are certainly better for small screen and also fit bigger screen, so I am ok with these. And you are right, password size should be checked during password creation not during authentication. The maximum size limit should be set to prevent overflow.

I merge your pull request, thank you again for your contribution.