Fix for the init script for Postgres 15

Crivaledaz / Mattermost-LDAP

This module provides an external LDAP authentication in Mattermost for the Team Edition (free).

MIT License

365 stars 72 forks source link

Fix for the init script for Postgres 15 #99

Closed florianschmeding closed 1 year ago

florianschmeding commented 1 year ago

The Demo docker-compose file has no major version set for Postgres and the DB init-script fails for Postgres 15.

A possible fix is to make the database user the owner of the created database within the init script.

Background informations:

https://stackoverflow.com/questions/74110708/postgres-15-permission-denied-for-schema-public
https://www.postgresql.org/about/news/postgresql-15-released-2526/ Other Notable Changes: "PostgreSQL 15 also revokes the CREATE permission from all users except a database owner from the public (or default) schema."

florianschmeding commented 1 year ago

Closing the PR, because in the meantime it was already fixed in c65ae73

Crivaledaz commented 1 year ago

Hi,

I am so sorry that I forgot about your pull request, which was completely valid. I believe I read your PR in December, but with the Christmas holidays, I forgot about it.

The worst part is that I discovered the bug during my tests in April and spent some time analyzing it to find a solution. When I discovered what the problem was, it seemed familiar to me, and I wondered why it had not been solved already.

I am truly sorry for the delay and appreciate your contribution.

Best regards