search

CroatianMeteorNetwork / RMS

RPi Meteor Station
https://globalmeteornetwork.org/
GNU General Public License v3.0
176 stars 49 forks source link

Auto reprocessing triggers #153

Closed g7gpr closed 6 months ago

g7gpr commented 1 year ago

The comment at

https://github.com/CroatianMeteorNetwork/RMS/blob/master/RMS/StartCapture.py#L580

# Check if there is a processed archived dir for every captured dir

I don't think this check actually happens, maybe the comment is out of date. I don't think it is a good idea to reprocess after the archive directory is deleted, the actual checks implemented are much better.

markmac99 commented 1 year ago

I don't think this is a bug. The comment is terse, but the code doesn't actually create a new archived folder for every captured one, it only does this if there are unprocessed pickle files and no ftpdetect. So its doing the right thing. I'm not sure its worth opening a PR just to reword the comment I'm afraid though I'll do it if later on I'm making changes in this file.

g7gpr commented 6 months ago

Fixed in pr #250