CroatianMeteorNetwork / RMS

RPi Meteor Station
https://globalmeteornetwork.org/
GNU General Public License v3.0
178 stars 50 forks source link

Queued pool can stop working on type error #186

Closed g7gpr closed 1 year ago

g7gpr commented 1 year ago

https://github.com/CroatianMeteorNetwork/RMS/blob/fbe535392c59cfb9238f426f96492b35d29a8439/RMS/StartCapture.py#L293

can assign a non integer to delay_detection.

This gets used to instantiate the pool, at https://github.com/CroatianMeteorNetwork/RMS/blob/fbe535392c59cfb9238f426f96492b35d29a8439/RMS/StartCapture.py#L310C52-L310C52

https://github.com/CroatianMeteorNetwork/RMS/blob/fbe535392c59cfb9238f426f96492b35d29a8439/RMS/QueuedPool.py#L430

then assigns a non integer value to worker timeout. If the worker does timeout after this, then

https://github.com/CroatianMeteorNetwork/RMS/blob/fbe535392c59cfb9238f426f96492b35d29a8439/RMS/QueuedPool.py#L437

fails because it is expecting an integer value.

I can submit a PR, but not for a few days.

g7gpr commented 1 year ago

Ref PR #187

g7gpr commented 1 year ago

Please leave open until the fix is observed to work in a real case, rather than testing.

g7gpr commented 1 year ago

Closing, as pool closed without a crash during observation on 2023-09-07.