CroatianMeteorNetwork / RMS

RPi Meteor Station
https://globalmeteornetwork.org/
GNU General Public License v3.0
169 stars 47 forks source link

small change to SkyFit2 to save the FF name in the state file. #263

Closed markmac99 closed 5 months ago

markmac99 commented 5 months ago

I've amended skyfit2 to include the FF filename in the state file. Now, if you run SkyFit2 on a folder containing more than one FF file, you can either a) use the folder as before, move between FF files and then work on the one you want to use; or b) load the state file. In this case, the right FF file is automatically loaded for further analysis

I've done some testing with fireballs without any issues, but would appreciate further review / input.

Closes #262

satmonkey commented 5 months ago

almost perfect! however, when using the --fr switch, and starting the fireball reduction on the FR file, restoring the state jumps to the FF file, not FR. It allows to resume the reduction though, but this is a minor side effect.

satmonkey commented 5 months ago

correction, after one more check, this works fine even for FR files.

dvida commented 5 months ago

Great! Have you tried opening old state files that were generated with previous version of skyfit?

markmac99 commented 5 months ago

@dvida I think so, but i will double check just in case.

satmonkey commented 5 months ago

does not work with old state files here. Takes the 1st FF file as default.

dvida commented 5 months ago

Good, as long as it doesn't throw an error. I'll now do a final test on non-RMS data and merge.

markmac99 commented 5 months ago

@dvida confirmed that when i load an older state file, the programme behaves as previously and loads the 1st available FF file.

This means that could be the wrong image for the state, but this is as expected since the correct filename isn't stored in the state.

markmac99 commented 5 months ago

@satmonkey yea thats as expected because the ff name is not available in the state :) so the behaviour is as it was previously (all that can be done).

satmonkey commented 5 months ago

I got it :) good job

dvida commented 4 months ago

Sorry to reopen this - has anyone tried moving the data directory to a different path? Will this new feature work then? E.g. the use cause might be when sharing the reduction with someone.

satmonkey commented 4 months ago

yes, this works with me, too