search

Croebh / Avrae-Customizations

A place for me to store and update all of my Avrae aliases and customizations.
GNU General Public License v3.0
28 stars 23 forks source link

[Feature Request] Make `!conc` take the Eldritch Mind invocation into account #56

Open tsintzask opened 3 years ago

tsintzask commented 3 years ago

What alias/snippet is this for? !conc

Is your feature request related to a problem? Please describe. The !conc alias currently automatically applies advantage for characters with the War Caster feat, but not to ones with the Eldritch Mind invocation. This feels like a bit of an inconsistency.

Describe the solution you'd like It would be nice if !conc automatically applied advantage on checks when the active character is one with the Eldritch Mind invocation, like it already does for the War Caster feat. Something like changing line 5 in the code of conc.alias to the following would work to include Eldritch Mind, I believe.

warcaster = 'warcaster' in get('feats', '').lower().replace(' ', '') or 'eldritchmind' in get('invocations', '').lower().replace(' ', '')

Describe alternatives you've considered !conc adv works, but it is easy to forget on occasion, especially given that the War Caster feat's advantage is automatically applied. Before I was subscribed to the workshop version, I had altered my personal !conc alias to make it work, too, but I feel like requesting this for the workshop alias would help more people than just me.

Additional context N/A

MobiusMage commented 3 years ago

I was just working on another version of my own last night that took the Circle of Stars Dragon Constellation Starry Form into account. Was going to add a pull request for it when I was satisfied with it, but I could add this in too before I do