[DRAFT] Make scast work with metamagic adept - Githubissues

Croebh / Avrae-Customizations

A place for me to store and update all of my Avrae aliases and customizations.

GNU General Public License v3.0

28 stars 23 forks source link

[DRAFT] Make scast work with metamagic adept #94

Open etriebe opened 1 year ago

etriebe commented 1 year ago

What Alias/Snippet is this for?

Update scast to work with a different custom counter for meta magic adept

Summary

Fix #36

Checklist

PR Type

[x] This PR is a code change that implements a feature request.
[ ] This PR fixes an issue.
[ ] This PR adds a new feature that is not an open feature request.
[ ] This PR is not a code change (e.g. documentation, README, ...)
Other
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] If code changes were made then they have been tested.
[ ] I have updated the documentation to reflect the changes.
[x] I properly commented my code where appropriate

etriebe commented 1 year ago

Questions: How do I test this? Is there a way to get avrae to test with a PR? Do I need to unsubscribe from the existing collection and make my own? This is my first time modifying a github repo and creating a PR for an alias. What does the cc_out line do on line 71? I'm attempting to make this work with arrays, since technically someone could have metamagic and be metamagic adept (IIRC). If that can't be the case, I'll do an either-or situation.

@Croebh