CroissantDuNord / discord-adblock

Hide Ads For Discord Nitro, with CustomCSS
MIT License
47 stars 7 forks source link

Remove the new "Apps & Commands" button #33

Closed VL4DST3R closed 2 months ago

VL4DST3R commented 2 months ago

Today I noticed a new button popped up next to the message field after the gif/sticker/emoji buttons.

It's useless and would love to get rid of it.

image

EDIT: found this filter rule for UBO mentioned on a reddit thread and figured it could be useful:

discord.com##div[class^="channelAppLauncher"]

nixRidge commented 2 months ago

Heya, and thanks for the issue.

I've already blocked this in the new adblock-extras file, where by request, I've moved anything that isn't strictly ads so people can keep things like profile customisations and still block ads.

Do you think this rule should be moved to the main list?

Cheers!

VL4DST3R commented 2 months ago

Do you think this rule should be moved to the main list?

Hey, thanks for the reply! Honestly? yes, as people mentioned on that reddit thread, this thing is 99% ads and garbage sponsored apps, plus it messes with the layout eating up space for narrow screens more than it is of any real use.

Moreover having it on the extras file would mean people would be also removing the rest of the features present there, something which many (for example myself) may not want.

nixRidge commented 2 months ago

Agreed, I'll move it. Thank you.

VL4DST3R commented 2 months ago

As time goes on this may actually become a bigger issue, with more and more questionable features being added, and I'm not sure if adding separate lists for them is the most sustainable approach.

Having this as a proper vencord/bd plugin would be the most flexible approach but I guess its not really urgent yet. "Cross that bridge when you get there" and all that.

nixRidge commented 2 months ago

I'm with you on that, I have actually been looking into making this a Vencord plugin that lets people pick what they want to block. Problem is I'm drawing complete blanks on how that'd work, for now. Need to sit down and properly learn how to work with TypeScript when I have free time.

The split lists are just a stopgap solution for the time being. However another problem with such a plugin would be how often the plugin can be updated on Vencord, since the plugins are all built with Vencord itself. Though, if the plugin could load external css files then no biggie.