search

Crompulence / cpl-library

http://www.cpl-library.org
Other
24 stars 9 forks source link

Remove nstep, initialstep and dt from setup (and density?) #11

Closed edwardsmith999 closed 8 years ago

edwardsmith999 commented 8 years ago

I propose these be removed as they are not essential and currently serve as a check only. I will add a routine CPL_set_times(nsteps, initialstep, dt) to broadcast and setup the coupled time so the user can do this if they want. Any objections? Means another interface changed but better now than before release...

edu159 commented 8 years ago

I agree on that. It is something I thought before. Makes more general cpl_setup routines.

Edu

Sent from my iPad

On 09 Jun 2016, at 19:47, Ed Smith notifications@github.com wrote:

I propose these be removed as they are no essential and currently serve as a check only. I will add a routine CPL_set_times(nsteps, initialstep, dt) to broadcast and setup the coupled time so the use can do this if they want. Any objections? Means another interface changed but better now than before release...

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

edwardsmith999 commented 8 years ago

Done, I've updated tests and examples and removed the website build from .travis file so we don't get test failure.