search

Cropster / ember-l10n

A GNU gettext based localization workflow for Ember
MIT License
15 stars 7 forks source link

Some strings are not extracted even after upgrading to 5.2.0 #101

Closed progmatic-99 closed 2 years ago

progmatic-99 commented 2 years ago

Strings were not being extracted with v4.1.3 and after upgrade they are still not being extracted

See this

@mydea Can you help as this is a priority issue as most of our customers are non-English speakers??

Thanks a lot!!

mydea commented 2 years ago

Can you provide more information? What strings are not being extracted, for example? If you can provide some code that is not properly extracted I can look into it.

progmatic-99 commented 2 years ago
progmatic-99 commented 2 years ago

@mydea Thanks

mydea commented 2 years ago

I don't understand the problem, I think?

When I run ember l10n:extract on this branch: https://github.com/progmatic-99/open-event-frontend/tree/translation, I can see that these things are correctly picked up, as far as I can tell.

progmatic-99 commented 2 years ago

We have a script that runs when we run yarn l10n:extract. See the command here This won't be needed anymore, ig???

mydea commented 2 years ago

I would recommend just using ember l10n:extract to extract strings. This will generally work and extract all strings and update the en.po & messages.pot file correctly. Not sure what happens in that script of yours. You can just do this in your package.json:

"scripts": {
  "l10n:extract": "ember l10n:extract"
}

You should also generally not need the generate stuff, just run extract and it should be fine.