CrossBreezeNL / crossmodel

An open-source logical data modeler to support the model driven data engineering approach.
GNU Affero General Public License v3.0
8 stars 3 forks source link

Implemented unit test in build #30

Closed harmen-xb closed 1 year ago

harmen-xb commented 1 year ago
harmen-xb commented 1 year ago

@martin-fleck-at

As part of this PR for unit tests in the build I did some extra things which I want to check with you:

  1. I first manually remove some packages from the package.json file in the root. After some other commits I realized that by doing this the yarn.lock is not updated. So I performed a 'yarn upgrade' to rebuild the yarn.lock based on the specified package versions. I do realize all dependencies are also updated if newer version are available wihin the version spec. Is this ok?
  2. At some point I got errors on the moduleResolution setting. I then looked into the Theia repository and synched the settings with that repo in this commit: https://github.com/CrossBreezeNL/crossmodel/pull/30/commits/13585623ac9305a241109b930e49832fab813dcf. Does this have any dowside/side-effect I am not aware of?
  3. I had issues with EsLint at some point which was due to an error in the include paths, which was fixed (https://github.com/CrossBreezeNL/crossmodel/pull/30/commits/0c42af9bb54620bb94ba50e92350be24cd1654ef). But before this fix I thought it was due to the tsconfig being wrong for the workspace or something. So I aligned it to be like the Theia or Theia Blueprint repo: https://github.com/CrossBreezeNL/crossmodel/commit/ab2a8fbb459ea2921e5154af4332a3867babd65e. Is this ok? Cause to me it looks better somehow, but again I don't know the side-effect of these changes.
  4. I enabled executing 'yarn lint' in the workflow, but only for Ubuntu (since it's the fastest). I did this because if I understand it correctly, lint should have the same result in all OSes right? (https://github.com/CrossBreezeNL/crossmodel/commit/7b70a41b732f9219f3010ed2acfe1ef3b819cc97)
github-actions[bot] commented 1 year ago

Test Results

    3 files    30 suites   1m 12s :stopwatch:   68 tests   68 :heavy_check_mark: 0 :zzz: 0 :x: 207 runs  207 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 44c07e45.

:recycle: This comment has been updated with latest results.