CrossBreezeNL / crossmodel

An open-source logical data modeler to support the model driven data engineering approach.
GNU Affero General Public License v3.0
8 stars 2 forks source link

Move React components to separate package and unify data handling #32

Closed martin-fleck-at closed 10 months ago

martin-fleck-at commented 10 months ago
github-actions[bot] commented 10 months ago

Test Results

    3 files  ±0    30 suites  ±0   56s :stopwatch: -37s   68 tests ±0    68 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  207 runs  ±0  207 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 24b016cd. ± Comparison against base commit f8c9c689.

:recycle: This comment has been updated with latest results.

martin-fleck-at commented 10 months ago

@harmen-xb As we are already touching the dependencies, I saw that you can check the dependencies for each package using npx depcheck. It is static so probably only using the import statements but it can give you a good idea of what might be missing or unused. However, it does not check the scripts that we are using our package.json so we should always manually double check if something is truly unused.

If you want, I can do a cleanup commit but maybe you want to do it.

harmen-xb commented 10 months ago

o probably only using the import statements but it can give you a good idea of what might be missing or unused. However, it does not check the scripts that we are using our package.json so we should always manually double check if something is truly unused.

I indeed used npx depcheck to see whats needed, thanks!