Add support for textual expressions in attribute mappings

CrossBreezeNL / crossmodel

An open-source logical data modeler to support the model driven data engineering approach.

GNU Affero General Public License v3.0

8 stars 2 forks source link

Add support for textual expressions in attribute mappings #56

Closed martin-fleck-at closed 3 months ago

martin-fleck-at commented 3 months ago

Allow specifying expressions in attribute mappings as string
Validate reference expressions '{{expression}}'
Provide suggestions for reference expressions
Allow attribute mappings to have 0 to n sources (previously 1)

Minor:

Guard return value in selection data service for undefined references

github-actions[bot] commented 3 months ago

Unit Test Results

3 files ±0 30 suites ±0 2m 29s :stopwatch: -9s 71 tests ±0 71 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 216 runs ±0 216 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0

Results for commit 83e9f602. ± Comparison against base commit f0b6dc8f.

:recycle: This comment has been updated with latest results.

harmen-xb commented 3 months ago

@martin-fleck-at

Expressions look good and nice to see the completion working!

Some things:

The suggestion in the expression works when we type {{ and press ctrl+space. But when we have {{ with any character after it, like a partial name, it doesn't work.
When clicking on a validation error ("Only sources can be ...") it opens the graphical mapping, i.s.o. jumping to the code where the error is. Or jumping to the new-form of the next PBI is also fine.

martin-fleck-at commented 3 months ago

@harmen-xb I adapted the behavior as you mentioned and now everything should work as expected. Please have another look.