Support editing source object specification in property view

[martin-fleck-at]

• Rename 'relations' to 'dependencies'
• Remove relationship conditions and only keep join conditions (MVP)
• Enhance expression to support more operators and literals
• Add form for source objects to edit dependencies and join condition
• Improve completion provider for non-text keywords
• Split model reducer actions into separate files for better devex

[github-actions[bot]]

Unit Test Results

  3 files  ±0   30 suites  ±0   2m 35s :stopwatch: -1s  71 tests ±0   71 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  216 runs  ±0  216 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit f8b6fd26. ± Comparison against base commit 102cc553.

:recycle: This comment has been updated with latest results.

[harmen-xb]

@martin-fleck-at

After testing the new source object setup we stumbled across a limitation which needs to be addressed. I wrote the changes in the user story here: https://dev.azure.com/x-breeze/CrossModel/_workitems/edit/869

[martin-fleck-at]

@harmen-xb Thank you for the feedback! I'll try to push an update by end of day tomorrow.

[martin-fleck-at]

@harmen-xb I pushed another commit that should take of moving the conditions up to the source object directly.

[harmen-xb]

@martin-fleck-at

The changes look good. This definitely makes sense modeling wise.

I have a couple of change requests:

1. I see an issue with the conditions when the source object is removed. If you create conditions containing a source object, these are not removed when you remove the source object. At a minimum I think we should validate the conditions, that they refer only to source objects which are listed in the dependencies (or the current object or literals).
2. Another issue I see is that you can select the current object as a dependency. I think you should remove the current object from the drop-down to make sure this is not selected. Also a validation needs to be added that a dependency can only be an source object within the same mapping, except for the current source object.
3. Could you add another validation: within one mapping there can only be one sourceobject with jointype from.
4. In the conditions part of the property form, could you make the Operator column written in full i.s.o. the 'OP'? I think there is enough space and makes it a lot more clear.

[martin-fleck-at]

@harmen-xb Thank you for your feedback! I pushed another commit that should now hopefully iron out the last issues.