search

CrossLead / angular-zendesk-widget

Angular wrapper for the Zendesk Web Widget
Apache License 2.0
18 stars 11 forks source link

Make it possible to disable the module without removing it #14

Open nigelsim opened 6 years ago

nigelsim commented 6 years ago

We need to be able to turn ZenDesk off in certain environments, so instead of requiring the config, this change simply disabled the module if the config isn't present.

yangchristian commented 6 years ago

Thanks @nigelsim. Could you also adjust the tests so they pass?

nigelsim commented 6 years ago

For sure, it'll just be a couple of days until I will have the chance. Thanks

On 18 Jan. 2018 14:38, "Christian Yang" notifications@github.com wrote:

Thanks @nigelsim https://github.com/nigelsim. Could you also adjust the tests so they pass?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CrossLead/angular-zendesk-widget/pull/14#issuecomment-358535616, or mute the thread https://github.com/notifications/unsubscribe-auth/AAALNemoE-8VakKs3qnJEyOhzo3x9sFCks5tLsrVgaJpZM4RiO36 .