search

CrossNox / m2r2

Markdown to reStructuredText converter
https://crossnox.github.io/m2r2
MIT License
107 stars 26 forks source link

fix: sphinx finally deprecated old `add_source_parser` in 3.3, returning `AttributeError` #14

Closed dcaba closed 3 years ago

dcaba commented 3 years ago

This addresses https://github.com/CrossNox/m2r2/issues/13

Given add_source_parser() in sphinx 3.3 has changed the signature (https://github.com/sphinx-doc/sphinx/pull/8280), invocations with the extra params result in AttributeError exceptions, not TypeError, so adding this condition to the failback logic to consume the latest signature when that occurs.

dcaba commented 3 years ago

@CrossNox , any chances of reviewing and potentially merging this? We cannot use the plugin in the latest sphinx releases...

aburrell commented 3 years ago

Locally this fix solves my problem. Using OSX Mojave, python 3.7.

CrossNox commented 3 years ago

Will review shortly, sorry, it's been a rough week

CrossNox commented 3 years ago

@dcaba thanks so much for the PR! To everyone else: sorry for the delay. I'll create a tag and release ASAP.

dcaba commented 3 years ago

Hi @CrossNox : better late than never. Thanks in any case for bringing the fix in the end, I see the new release is now public. BTW, what should we expect regarding this project maintenance? Of course I just aim for a best-effort maintenance, but if you are afraid you don't have too much focus, should we try to bring in more maintainers, or should we just assume the delay was a result of a very exceptional situation?

CrossNox commented 3 years ago

IMHO, despite my personal situation at any time given (which rn depends on university deadlines) m2r failed because there was a single mantainer, which is a SPOF. I'll be opening a new issue explaining all this and making clear that I'd prefer to have other people involved as collaborators. Not just because of new features, but because any changes such as seen these past weeks breaks a fair amount of projects, and m2r2 should quickly give support to it. That should not depend on a single person, even if they had all the time for it.

dcaba commented 3 years ago

Hi @CrossNox : better late than never. Thanks in any case for bringing the fix in the end, I see the new release is now public. BTW, what should we expect regarding this project maintenance? Of course I just aim for a best-effort maintenance, but if you are afraid you don't have too much focus, should we try to bring in more maintainers, or should we just assume the delay was a result of a very exceptional situation?

Hi. Yes, we are on the same page: however, not in a position to say what you should do with your repo, but happy to see you just want to do the best for the project (some other maintainers do not want to share their "pets", no matter if that is the best for them or not ;) )