Update for docutils 0.19

CrossNox / m2r2

Markdown to reStructuredText converter

https://crossnox.github.io/m2r2

MIT License

107 stars 26 forks source link

Update for docutils 0.19 #49

Closed codeThatThinks closed 2 years ago

codeThatThinks commented 2 years ago

ErrorString and SafeString are deprecated and have been removed in docutils 0.19. This PR replaces ErrorString with io.error_string and SafeString with Python's builtin str().

See docutils:HISTORY.txt and docutils:utils/error_reporting.py for more information.

CrossNox commented 2 years ago

Thanks for the PR! Seems straighforward, but I will look into it later tonight.
My concern is that python2.7 seems to be incompatible with the latest docutils versions, so I'll run the full tests suite and check.

CrossNox commented 2 years ago

Ok, so my plan is as follows:

Merge this PR and release a new version, so as to avoid broken pipelines (forcing docutils <= 0.18 seemed weird in this regard)
Drop python2 support altogether in a future release. I'll be thinking what the best way to go about that would be.

adrien-berchet commented 2 years ago

Hi @CrossNox Would it be possible to release a new version as you planned please? As you said, it's a bit annoying to force docutils <= 0.18 in every repos. Thanks

CrossNox commented 2 years ago

Yep, sorry, had my last final last night. Will work on this later today. Tests were not passing and was not quite as straightforward as I had planned.

adrien-berchet commented 2 years ago

Ok, I see, no problem. Thank you very much to work on this :)