search

CrossNox / m2r2

Markdown to reStructuredText converter
https://crossnox.github.io/m2r2
MIT License
107 stars 26 forks source link

Fix missing setuptools dependency #64

Closed FlotterCodername closed 2 months ago

FlotterCodername commented 9 months ago

Fixes https://github.com/CrossNox/m2r2/issues/63

parona-source commented 9 months ago

Alternatively importlib.metadata could be used, its not available in the now EOL python3.7 but it does have a backport.

pkg_resources is discouraged either way by setuptools https://setuptools.pypa.io/en/latest/pkg_resources.html.

The use here is very minimal and can be changed like I did here https://github.com/nicolasbock/ebuildtester/pull/212/commits/e95c34296eb56d55ffca5b38947602e91d73729c

Only minus is python 3.7 requiring a backport, but python3.7 should be dropped from the CI by now already...

oscargus commented 2 months ago

pkg_resources is dropped in setuptools 70, so it should either be pinned to <70 or, better, use importlib.

FlotterCodername commented 2 months ago

pkg_resources is dropped in setuptools 70, so it should either be pinned to <70 or, better, use importlib.

Thanks for the headsup! In this case I'm going to close the PR. I think pinning a package like setuptools is not acceptable. With no response from maintainers in half a year it appears hopeless to get a merge for the correct approach. I've migrated everything to MyST already anyway. The success of MyST is probably also a reason why this package now appears abandoned.