CrossTheRoadElec / Phoenix-Releases

Release repository for Phoenix-Framework and Phoenix-Tuner
79 stars 6 forks source link

WPI_PigeonIMU not compatible with the Gyro Shuffleboard Widget #23

Closed IShaLinI closed 2 years ago

IShaLinI commented 2 years ago

The WPI_PigeonIMU class implements Sendable in a way that makes it incompatible with the Gyro Widget.

Current initSendable method:

@Override
public void initSendable(SendableBuilder builder) {
    builder.setSmartDashboardType("Pigeon IMU");
    builder.addDoubleProperty("Heading", this::getFusedHeading, null);
}

The SmartDashboardType and the key "Heading" make it not able to be displayed with the Gyro Widget.

Fixed initSendable method:

@Override
public void initSendable(SendableBuilder builder) {
    builder.setSmartDashboardType("Gyro");
    builder.addDoubleProperty("Value", this::getFusedHeading, null);
}
CoryNessCTR commented 2 years ago

Thanks for the Issue! This seems like a simple enough update, we've got it noted in our private tracker and will try to get it into the next release.

CoryNessCTR commented 2 years ago

Release https://github.com/CrossTheRoadElec/Phoenix-Releases/releases/tag/v5.21.1.0 has this fixed