CrossTheRoadElec / Phoenix-Releases

Release repository for Phoenix-Framework and Phoenix-Tuner
76 stars 7 forks source link

Talon commanded voltage has delayed reporting on 2023 firmware #38

Open Oblarg opened 1 year ago

Oblarg commented 1 year ago

Per discussion in the FRC discord, we're seeing negative calculated values for measurement delay when users run SysId routines on 2023 Talons:

image

From the SysId source, we can see these values are computed as follows:

image

Both values are computed from the step voltage test data.

The simplest explanation for this is that somehow the voltage data is delayed compared to the position data. SysId's robot binary queries the motor controller API to determine applied voltage, and this is only being observed with CTRE devices, so it seems like it might be a result of 2023 firmware changes.

sciencewhiz commented 1 year ago

I can see CTRE needing several more pieces of information in order to investigate

What actual motor controller. Presumably you don't mean the PWM only Talon released in 2012 What version of Phoenix vendordep (current SysID releases use beta vendordeps, but there's other versions in the repo) What are the actual calls SysID uses for retrieving the voltage and motion, as there are sometimes different methods with different update rates.