search

CrossTheRoadElec / Phoenix-Releases

Release repository for Phoenix-Framework and Phoenix-Tuner
76 stars 7 forks source link

Python phoenix6 package is unusable for type checking #61

Closed auscompgeek closed 5 months ago

auscompgeek commented 6 months ago

We're unable to run the mypy type checker on our robot code after migrating to phoenix6. Example output:

Error: components/chassis.py:3:1: error: Skipping analyzing "phoenix6": module is installed, but missing library stubs or py.typed marker  [import-untyped]
components/chassis.py:3:1: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports

Could we please get a py.typed marker file in the package, per PEP 561?

CoryNessCTR commented 6 months ago

This is fixed in the 24.1.0 release

auscompgeek commented 6 months ago

I'm not seeing a py.typed in the phoenix6 package in 24.1.0.

auscompgeek commented 5 months ago

I can confirm phoenix6 24.2.0 has a py.typed; thanks!