getOutputCurrent() is in BaseMotorController but presumably not supported by SPX

CrossTheRoadElec / Phoenix-api

CTRE Phoenix language API (targets FIRST Robotics Competition, Linux, RaspPi, Windows)

Other

39 stars 28 forks source link

getOutputCurrent() is in BaseMotorController but presumably not supported by SPX #26

Closed ryegleason closed 3 years ago

ryegleason commented 6 years ago

According to https://content.vexrobotics.com/vexpro/pdf/VictorSPX-InfoSheet-20171129.pdf, the Victor SPX can't measure current, but it still has the getOutputCurrent() method it inherits from BaseMotorController. This should probably be moved to TalonSRX.

ozrien commented 6 years ago

This is correct and I agree. In the meantime I expect the return is zero amps when used with the Victor SPX.

aswerdlow935 commented 6 years ago

Yes, the return is zero.....only saw this after testing for days with the method only to later realize it was always returning zero. Should definitely be moved (or at the least have a warning put in for now).

ozrien commented 6 years ago

Depending on what you are trying to accomplish, you can poll the current via PDP.

JCaporuscio commented 3 years ago

This has been fixed since 5.8.0