search

Crossing-Tech / akka-osgi-sample

Apache License 2.0
4 stars 3 forks source link

Integration testing #1

Closed rocketraman closed 11 years ago

rocketraman commented 11 years ago

Here is the pull request we discussed this morning.

Crossing-Tech commented 11 years ago

Beautiful work! What about moving directly to akka 2.2-SNAPSHOT?

Crossing-Tech commented 11 years ago

great! thanks for your changes!

rocketraman commented 11 years ago

Working on the Akka 2.2-SNAPSHOT now...

rocketraman commented 11 years ago

Ah wait... I wanted to rebase the "fixup" commits before merge.

Also, it seems like the 2.2-SNAPSHOT is missing the OSGi meta-data in akka-actor.jar and perhaps others...

Manifest-Version: 1.0
Implementation-Vendor: Typesafe Inc.
Implementation-Title: akka-actor
Implementation-Version: 2.2-SNAPSHOT
Implementation-Vendor-Id: com.typesafe.akka
Specification-Vendor: Typesafe Inc.
Specification-Title: akka-actor
Specification-Version: 2.2-SNAPSHOT

We should probably post on the ML about that...

rocketraman commented 11 years ago

Can I force push the branch without the "fixup" commits, and you can redo the merge?

Crossing-Tech commented 11 years ago

there are no akka-actor bundle in version 2.2-SNAPSHOT, it is wrapped into akka-osgi yes, I will.

by the way, you are using akka bundle in version 2.2-SNAPSHOT but you're compiling with 2.1.0, am I right? It may not be really important, from the moment akka moves it in their build, it is maybe easier to compile on 2.2

rocketraman commented 11 years ago

No, I'm compiling with 2.2. Thanks for the info about akka-actor, I didn't know that -- let me update.

Crossing-Tech commented 11 years ago

Don't worry, I will amend the two lasts commits and push

Crossing-Tech commented 11 years ago 
<properties>
        <akka.version>2.1.0</akka.version>
...
Crossing-Tech commented 11 years ago

push done, if it's ok for you