search

Crossroads-Development / Crossroads

Crossroads is a mod for Minecraft. It adds a lot of content, and has the design philosophy of "simple pieces, complex contraptions".
MIT License
29 stars 14 forks source link

Destroyng Large Gears with Supplementaries #244

Closed Lucksinia closed 1 year ago

Lucksinia commented 1 year ago

Describe the bug While turning Large Gears with wrench from Supplementaries, it getting deleted

To Reproduce [Optional] Steps to reproduce the behavior:

  1. Place any Large Gear on any block.
  2. With Supplementaries Wrench Right-Click on embedded axle
  3. See turning particles, but no Gear.

Screenshots 2023-03-07_15 38 27 2023-03-07_15 38 30

Expected Behavior Turning Gear or nothing at all, like with small gears.

Considering that normal gears just ignore it, and base of Large Gears ignore wrench to... Maybe just delete axle part on model..?

The-Minecraft-Scientist commented 1 year ago

Did a bit of research, the way to make the Supplementaries wrench actually work with CR block entities would be to build against Moonlight Utils and implement IRotatable for them (woohoo more compile time dependencies) (possibly harnessing the way the CR wrench already works) or just have Supplementaries blacklist Crossroads blocks for use with their wrench.

Da-Technomancer commented 1 year ago

Fixed in the 02c8d4f. Thanks @The-Minecraft-Scientist for the help, went with the blacklist route you identified.