search

Crossroads-Development / Crossroads

Crossroads is a mod for Minecraft. It adds a lot of content, and has the design philosophy of "simple pieces, complex contraptions".
MIT License
29 stars 18 forks source link

Modular Golems Glowing Incompatibility #293

Open The-Zekenator opened 1 week ago

The-Zekenator commented 1 week ago

Describe the bug This mod and Modular Golems (https://www.curseforge.com/minecraft/mc-mods/modulargolems) appear to have conflicting behavior regarding a glowing effect that MG uses when mousing over one of its golems.

To Reproduce [Optional] Steps to reproduce the behavior:

  1. Have Modular Golems, L2 Library, and Crossroads and Essentials installed.
  2. Spawn a golem from MG.
  3. Mouse over it with any wand that targets a golem or an enemy (Command Wand, Retrieval Wand, etc). The golem or entity will begin glowing.
  4. The glow will not fade, no matter what you do until you log back out or switch dimensions.

Expected behavior [Optional] Normally, Modular Golems should have the glow fade after a few moments. But with Crossroads installed, the glowing effect persists forever, until entity death or logging out and back in. I'm not sure why this occurs. It appears to be a Crossroads-specific problem as Essentials does not cause this. Since Crossroads from my play with it appears to be a tech mod, I'm not sure why it would interfere with this.

Additional context [Optional] I've tested this alone with just the four mods involved and in a modpack with about 230 mods. This incorrect behavior is present in both contexts.

Modular Golem's source code is available here, if that helps (https://github.com/Minecraft-LightLand/ModularGolems).

lcy0x1 commented 1 week ago

I’m the dev of ModularGolems. The point of conflict is here: https://github.com/Minecraft-LightLand/L2Library/blob/1.19/src/main/java/dev/xkmc/l2library/mixin/EntityMixin.java

I mixin into Entity class to make isCurrentlyGlowing return true for some entities. Did crossroad cache this value somehow? My mixin should return true only when player is pointing at them with a specific item.