Crossroads-Development / Essentials

Essentials is a mod for Minecraft. It adds a few simple utility-style blocks and items, mostly meant to enhance vanilla-style automation.
MIT License
11 stars 10 forks source link

High-throughput hopper should verify item transfer result #74

Closed Da-Technomancer closed 2 years ago

Da-Technomancer commented 2 years ago

Describe the bug When the high-throughput hopper transfers items, it should check what is expected to happen for an item transfer using the simulate option, then based on the results it should attempt an actual item transfer. The amount of items it removes from itself should be based on the results of the actual item transfer, not the simulated item transfer (under certain conditions when using other mods, the two can vary); currently it trusts the simulated item transfer, which while fine for vanilla applications, can cause item deletion in heavily modded environments.

As an example of somewhere that this caused trouble, see https://github.com/Crossroads-Development/Crossroads/issues/183

Issue may also have applicability to regular sorting hoppers?