search

CroudTech / vue-fullcalendar

FullCalendar Wrapper for vue
MIT License
483 stars 100 forks source link

defaultConfig change locale's timeFormat #166

Open padinko opened 6 years ago

padinko commented 6 years ago

Hi,

I am developing multi-locale application and I have a problem. Your defaultConfig contains timeFormat and it replace timeFormat from locale setting. So my question is why you hardcoded this value (to european time format) and is it necessary? I think you can remove this value from defaultConfig and let fullcalendar to use locale timeFormat or devs can set it in theirs config.

Now I need to replace your hardcoded timeFormat with this option:

            calendarConfig() {
                return {
                    locale: this.portal.lang,
                    timeFormat: null,
                    ...
                }
            },

Edit 1: Maybe aspectRatio have same problem, it is unnecessary to hardcode it in defaultConfig, leave fullcalendar's default and let dev to adopt it

Adrek commented 5 years ago

Please, add prop timeFormat. Currently this props doesn't work.