search

CroudTech / vue-fullcalendar

FullCalendar Wrapper for vue
MIT License
483 stars 100 forks source link

Change in class binding breaks rendering #208

Open gmw-web opened 5 years ago

gmw-web commented 5 years ago

When a calendar has a class binding with for example :class="{'disabled': !isActive}", and the isActive property changes, the changing class causes the rendering of the calendar to break.

See this codepen for a demo of the issue(click the button in the top left): https://codesandbox.io/embed/fullcalendar-vue-1lktx

BrockReece commented 5 years ago

Hmm, that is frustrating... I will try and have a look this afternoon.

BrockReece commented 5 years ago

I'm guessing this is a conflict between Vue and Fullcalendar's jQuery dom manipulation. Could you apply the class to a parent element?

gmw-web commented 5 years ago

Luckily, I can (and I did) use that workaround. I posted because I thought you (and others) should know. Hopefully it's fixable. Thanks for looking into the issue!

BrockReece commented 5 years ago

Ah ok, glad that solved it. Yeah I guess we could wrap the calendar target element with a parent to prevent this. Not sure whether it would break other's implementations though. One to think about going forward I think.