search

CroudTech / vue-fullcalendar

FullCalendar Wrapper for vue
MIT License
483 stars 100 forks source link

Resolves #42 #44

Closed dschreij closed 7 years ago

dschreij commented 7 years ago

This PR changes the functions eventDrop and eventResize, such that they pass through all parameters that they receive from fullcalendar. I also changed the remove-event listener function such that it not only allows removal of events by their ID, but also a filter function (for which the parameter name 'event' may be a bit inappropriate then), as described in the documentation of this function. This is useful when an event needs to be removed before it has been assigned an ID.

BrockReece commented 7 years ago

Awesome, thanks a lot. How about using the spread operator to clean things up a bit?

eventDrop(...args) {
    self.$emit('event-drop', ...args)
},

Cheers Brock

dschreij commented 7 years ago

Of course! I still have to get used to using this awesome ability more. I took the liberty of also updating this for all the other functions that I didn't touch last time.

BrockReece commented 7 years ago

@dschreij That is awesome 👍 , thanks.

I will bump the version up now.