search

CroudTech / vue-fullcalendar

FullCalendar Wrapper for vue
MIT License
483 stars 100 forks source link

Please require jquery in your component #52

Closed getriebesand closed 7 years ago

getriebesand commented 7 years ago

Please put

var $ = require('jquery')

in your FullCalendar.vue.

I don't need jquery but have another lib which defines $

And I think if your component depends on jquery, it should require it by it self.

BrockReece commented 7 years ago

I'm not sure if the $ definition is enough for fullcalendar to work as it is a jQuery plugin. See this codepen, the console ouput gives the following

Uncaught ReferenceError: jQuery is not defined

What do you have that defines $?

getriebesand commented 7 years ago

fullcalender imports jquery too. So we don't have to care about that.

BrockReece commented 7 years ago

But window.jQuery needs to be defined for jQuery to load plugins I think. So even if I am importing jQuery into the component. 

import $ from 'jQuery'

We are still going to see 

Uncaught ReferenceError: jQuery is not defined

Maybe I'm wrong?

BrockReece commented 7 years ago

Oh sorry, I see what you mean.

Ok, I'll commit something into a new branch and if you could test with your setup I will merge it in when we are ready.

getriebesand commented 7 years ago

Thank you. Now it works with my setup.

BrockReece commented 7 years ago

Perfect, I will merge it in. Thanks for your contribution