search

CrowCpp / Crow

A Fast and Easy to use microframework for the web.
https://crowcpp.org
Other
3.06k stars 340 forks source link

Http response: compressed flag can't not be set to false? #848

Open D-Latch opened 1 month ago

D-Latch commented 1 month ago

Hi in this issue 'Added HTTP compression using gzip or deflate #93' you said: 'I think for now it's best to disable gzip when streaming a response (whether it's static files or large responses), maybe will be added with websocket compression'

No matter how I set 'compressed' flag to false I still find header 'Content-Encoding' in my response. So I assumed that the authentic response returned is not the one I define but the one that is copied from it. Thus I thought compressed flag might forgot to be set in the copy-construct function and finally I got this:

2024-07-10_10-40

gittiver commented 1 month ago

looks like a bug. any comments on this?

D-Latch commented 1 month ago

Well, I'm not so sure because I think if it's a problem then it should have been found long time ago. However, there is a git comment bound to the param 'filei_nfo' saying: ' fix move assign operator not moving file_info'