search

CrowdDotDev / crowd.dev

⚡️ The developer data platform to centralize community, product, and customer data
https://crowd.dev
Other
3.27k stars 756 forks source link

Fix readme #2402

Closed olearycrew closed 3 months ago

olearycrew commented 3 months ago

Changes proposed ✍️

What

copilot:summary ​ copilot:poem

Why

How

copilot:walkthrough

Checklist ✅

CLAassistant commented 3 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 3 committers have signed the CLA.

:x: RKukharchuk
:x: olearycrew
:x: lisciojosh
You have signed the CLA already but the status is still pending? Let us recheck it.

gitguardian[bot] commented 3 months ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/workspace/288863/incidents/secrets) | | Generic High Entropy Secret | 7a9f10626902b006f04d54d3c267cbac2cbb171f | scripts/deploy/kubernetes/datadog-values.yaml | [View secret](https://github.com/CrowdDotDev/crowd.dev/commit/7a9f10626902b006f04d54d3c267cbac2cbb171f#diff-0c0026f6f9535c047ab4fb6fb742d3373ca5b976327dccfca9d9280d658c6028L6) | | [-](https://dashboard.gitguardian.com/workspace/288863/incidents/secrets) | | Generic High Entropy Secret | e70adf35ba61c57bc85577a2121b87b7570949c3 | scripts/deploy/kubernetes/cubejs.yaml | [View secret](https://github.com/CrowdDotDev/crowd.dev/commit/e70adf35ba61c57bc85577a2121b87b7570949c3#diff-43431b67d864dab816dc7b0e3130ad955e2989bf013afee461718c086582b46cR34) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.