search

CrowdHailer / Ace

HTTP web server and client, supports http1 and http2
https://hex.pm/packages/ace
MIT License
305 stars 26 forks source link

Fix incorrect warning for using Raxx.SimpleServer #129

Closed ishikawa closed 5 years ago

ishikawa commented 5 years ago

As reported in https://github.com/CrowdHailer/Ace/issues/127, the current Ace.HTTP.Service.start_link macro mistakenly emits warning even with use Raxx.SimpleServer. Because the module_info/0 function in each module can contain duplicate keys (doc), Ace.HTTP.Service should handle such a case:

[
  vsn: [65842577946200045591869981152062039094],
  behaviour: [Raxx.SimpleServer],
  behaviour: [Raxx.Server]
]
CrowdHailer commented 5 years ago

Thanks for this. tests and a good explanation. My favourite PR this year :smile:

ishikawa commented 5 years ago

Thanks for fix circleci failure 😊