search

CrowdHailer / Ace

HTTP web server and client, supports http1 and http2
https://hex.pm/packages/ace
MIT License
305 stars 26 forks source link

Bad Supervisor.start_child call #152

Open varnerac opened 4 years ago

varnerac commented 4 years ago

In Ace.HTTP2.Connection there is a call to Supervisor.start_child/2 that doesn't have a child spec as the second argument.

https://github.com/CrowdHailer/Ace/blob/master/lib/ace/http2/connection.ex#L751

I am not sure what it's trying to do or how it could work.

varnerac commented 4 years ago

Also here: https://github.com/CrowdHailer/Ace/blob/master/lib/ace/http/service.ex#L272

varnerac commented 4 years ago

Ok, I understand what happened here. Older versions of Elixir allowed the last argument to be a list of terms. That's no longer the case. This breaks dialyzer on recent version of Elixir.