search

CrowdHailer / Ace

HTTP web server and client, supports http1 and http2
https://hex.pm/packages/ace
MIT License
305 stars 26 forks source link

Cache PLTs in Github Actions #158

Closed pablocostass closed 4 years ago

pablocostass commented 4 years ago

Should close #157

ghost commented 4 years ago

Nice @pablocostass

ghost commented 4 years ago

@pablocostass did you see in Cory’s one he generates the plt filles and catches them in two steps https://github.com/coryodaniel/k8s/blob/develop/.github/workflows/ci.yaml

CrowdHailer commented 4 years ago

Looks good, worth moving more to Cory's style?

pablocostass commented 4 years ago

@bryanhuntesl No I hadn't, I just learnt that you can do conditionals with the cache step output like that!

@CrowdHailer If you'd rather use that approach I can do that. The only difference, however, between Cory's config and mine is that his handles the creation of the directory where Dialyzer's PLT will be generated purely from the CI config file, whereas mine expects the directory to exist (i.e., it does not mkdir it and that's why it has a .gitignore to force the directory to exist).

In short, if you think it's cleaner to have a conditional step to generate the PLT for the first time and otherwise call Dialyzer to do its checks instead of simply calling Dialyzer, I'll do the change :)

CrowdHailer commented 4 years ago

I'm really not sure. I haven't looked into the details yet. Happy to go with which ever yu think best

pablocostass commented 4 years ago

I would leave it as is, that way Dialyzer is just called once in either scenario (i.e., when creating the PLT or when checking for warnings).

CrowdHailer commented 4 years ago

Done