search

CrowdHailer / raxx

Interface for HTTP webservers, frameworks and clients
https://hexdocs.pm/raxx
Apache License 2.0
401 stars 29 forks source link

Fix Raxx.body spec #109

Closed varnerac closed 6 years ago

varnerac commented 6 years ago

Raxx.body was String.t(). Changes it to binary. String.t() implies it's a string. It may be a string, but could just as easily be a raw binary that's not a string.

CrowdHailer commented 6 years ago

Well you learn something new everyday.

This looks good, but as I know people who run dialyzer over raxx projects I still think this needs a mention in the changelog.

Perhaps I should also add something to an ISSUE_TEMPLATE saying about a changlog.

CrowdHailer commented 6 years ago

Also if chunked responses/requests can have binary data then should the spec of Raxx.Data should be changed?

varnerac commented 6 years ago

yeah

CrowdHailer commented 6 years ago

I think this also needs changing. https://github.com/CrowdHailer/raxx/blob/master/lib/raxx.ex#L233

Although I am curious to see if dialyzer is smart enough to pick it up

CrowdHailer commented 6 years ago

Thanks :whale: